adiemus Guest
|
Posted: Mon Oct 13, 2003 11:43 am Post subject: Minor Graph Template Items edit page modification |
|
|
I've set up several data templates and corresponding graph templates for data on the local machine. I've copied and modified these local templates in creating similar data templates and graph templates for SNMP hosts. But I find the current "Data Source" drop down in the Graph Template Items edit page to be confusing.
For example, I have a local data template named:
Linux - Memory - Cache
it's configured to show up in graphs as
|host_description| - Memory - Cache
which is fine. But then I created a data template named:
ucd/net snmp - Memory - Cache
which is also configured to show up in graphs as
|host_description| - Memory - Cache
Now, when editing a graph template, I end up with two drop down options named:
Memory - Cache (rrd_name_used)
I would find it much easier to have the drop down populated with the actual data template names, ie:
Linux - Memory - Cache (rrd_name_used)
ucd/net snmp - Memory - Cache (rrd_name_used)
To that end, I've modified graph_templates.php as follows:
--- graph_templates.php 2003-10-13 09:10:22.000000000 -0700
+++ graph_templates.php.new 2003-10-13 09:29:17.000000000 -0700
@@ -654,7 +654,7 @@
/* modifications to the default graph items array */
$struct_graph_item["task_item_id"]["sql"] = "select
- CONCAT_WS('',data_template_data.name,' (',data_template_rrd.data_source_name,')') as name,
+ CONCAT_WS('',data_template.name,' (',data_template_rrd.data_source_name,')') as name,
data_template_rrd.id
from data_template_data,data_template_rrd,data_template
where data_template_rrd.data_template_id=data_template.id
If I'm missing something here, let me know. Otherwise, I'd ask that this behavior be modified as described to help others avoid the confusion I've had.
Thanks,
Chris |
|