Cacti (home)ForumsRepositoryDocumentation
Cacti: offical forums and support  

 FAQFAQ   SearchSearch   MemberlistMemberlist    RegisterRegister   ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in    


IN/OUTCOMMENT feature request

 
Post new topic   Reply to topic    Cacti Forum Index -> Plugin: (Network Weather Map)
Author Message
wwwdrich
Cacti User


Joined: 03 Feb 2005
Posts: 59
Location: San Jose, CA

PostPosted: Tue Mar 25, 2008 10:11 am    Post subject: IN/OUTCOMMENT feature request Reply with quote

I love the new feature of interface comments in 0.9, however I have a slight problem with it. I really need more control over where the comments are placed. As you can see in the attached images, the logic for where to put them makes them a little unreadable for devices with a lot of connections.

Even some of my less-complicated devices are having issues with the comments slipping under the icons. This problem isn't the same for all devices either, as you can see from the 2nd attachment. I'm assuming it is because the links have different lengths, and the comments are being placed at a specific percentage of the link length?

I would really like to be able to do two things that I think would address my issues:
[list=]Specify the minimum offset from the end of the link -- ex. INCOMMENTMINOFFSET 25 would place the comment a minimum of 25 pixels from the start of the link, thereby preventing them from disappearing under the icons.
[list=]Allow an option for comments to sit on the link instead of next to it. I always try and make sure my links don't overlap too much to make for easier reading, if the comment was on the link it would always be visible.
[/list]

Thoughts?



weathermap-device-2.png
 Description:
 Filesize:  26.13 KB
 Viewed:  798 Time(s)

weathermap-device-2.png



weathermap-device-1.png
 Description:
 Filesize:  48.03 KB
 Viewed:  798 Time(s)

weathermap-device-1.png


Back to top
Howie
Cacti Guru User


Joined: 16 Sep 2004
Posts: 2162
Location: United Kingdom

PostPosted: Tue Mar 25, 2008 11:56 am    Post subject: Reply with quote

Since 0.92 you can adjust the position along the link with COMMENTPOS.

There's isn't a proper command for positioning distance perpendicular to the link, but I just noticed there *are* a couple of 'secret' SET commands, one of which is comment_nudgeout, which looks to be an offset in pixels, per-link. So something like:
Code:

LINK blah
  WIDTH 4
  SET comment_nudgeout -8

should do it. It takes the width+4 as the standard position for the comment away from the centre-line of the link. That should (untested) pull it back into the middle.

Bear in mind that if you put it over the link, then you're likely to run into readability issues as the link changes colour.
Back to top
wwwdrich
Cacti User


Joined: 03 Feb 2005
Posts: 59
Location: San Jose, CA

PostPosted: Wed Mar 26, 2008 3:15 pm    Post subject: Reply with quote

I find that white text is visible on most of the link colors -- at least with our current network that has way too much capacity at the moment so I rarely see links that aren't black or blue (using the gradient rainbow scale from one of the examples on our site).

One thing I did notice, the angle calculations for the comments don't always quite match the angle of the link. They are close, but sometimes slightly off. I'm working from home today, but I'll add a comment with some example images tomorrow. It's really noticible on links using VIA. And I'm sure I am going to be making lots of use of COMMENTPOS once .96 comes out.
Back to top
Howie
Cacti Guru User


Joined: 16 Sep 2004
Posts: 2162
Location: United Kingdom

PostPosted: Wed Mar 26, 2008 3:58 pm    Post subject: Reply with quote

wwwdrich wrote:
I find that white text is visible on most of the link colors -- at least with our current network that has way too much capacity at the moment so I rarely see links that aren't black or blue (using the gradient rainbow scale from one of the examples on our site).

One thing I did notice, the angle calculations for the comments don't always quite match the angle of the link. They are close, but sometimes slightly off. I'm working from home today, but I'll add a comment with some example images tomorrow. It's really noticible on links using VIA. And I'm sure I am going to be making lots of use of COMMENTPOS once .96 comes out.


It doesn't actually follow the curve - it picks the point at the start of the text, and finds the angle there. So if your curve is, well, curving at that point, the text will drift. Positioning each letter to match the curve is a lot more pain. I might try it at some stage, just for kicks, but after I revamp the link-drawing to include angled VIAs (should be in 0.96).

I don't follow what you are waiting for in 0.96 though. COMMENTPOS is in 0.92 onwards...
Back to top
wwwdrich
Cacti User


Joined: 03 Feb 2005
Posts: 59
Location: San Jose, CA

PostPosted: Wed Mar 26, 2008 4:28 pm    Post subject: Reply with quote

Ah, I misread your 0.92 up above as 0.96 -- it's been one of those days. I thought it wasn't there because I tried to use COMMENTOFFSET instead of COMMENTPOS and got an error.
Back to top
Display posts from previous:   
Post new topic   Reply to topic    Cacti Forum Index -> Plugin: (Network Weather Map) All times are GMT - 5 Hours
Page 1 of 1

 



Powered by phpBB © 2001, 2005 phpBB Group