Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 2167 Location: United Kingdom
|
Posted: Thu Dec 27, 2007 6:36 am Post subject: Looking for some guidance - use of constants in cacti code |
|
|
So rather than working on Weathermap stuff, I've been playing with adding extra data types to graph tree for the last couple of days... so far so good (it's not done yet though). It brings up a couple of questions though:
Is the stuff in global_constants.php arriving or leaving? Some code in tree* uses it, and some uses a plain string for the type. I assume that it should be updated to use the constants instead?
Second, how should I submit this stuff? It's going to be fairly heavy patches, but only to a few files, plus some additional database fields in graph_tree_items. |
|