Cacti (home)ForumsRepositoryDocumentation
Cacti: offical forums and support  

 FAQFAQ   SearchSearch   MemberlistMemberlist    RegisterRegister   ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in    


[SOLVED] Lower limit and upper limit variable support

 
Post new topic   Reply to topic    Cacti Forum Index -> Feature Requests
Author Message
llow
Cacti User


Joined: 05 Oct 2007
Posts: 88

PostPosted: Fri Oct 12, 2007 3:14 pm    Post subject: [SOLVED] Lower limit and upper limit variable support Reply with quote

It would be nice to be able to dynamicaly set the lower and upper limits through query or other variables.

The database structure would probably need to change lower_limit and upper_limit to a varchar(255).

I can work up a patch for 0.8.7 for this if anyone else thinks its a good idea.
Back to top
rony
Developer/Forum Admin


Joined: 17 Nov 2003
Posts: 5448
Location: Wisconsin, USA

PostPosted: Fri Oct 12, 2007 3:20 pm    Post subject: Reply with quote

Yep, it would be nice.

The only problem, and the reason it has yet to be implemented, is that updates to the RRDTool file are not made by Cacti once the file is created.

But to be honest, if you are going have dynamic variables, I would only want to apply them to the graph output.

Let's think of this, what if a max value where to be passed and applied to the data source, then the RRDTool file was updated, but this value was below past maximum values in the RRDtool file. Would those maximum values be retained or trimmed in the RRDtool file?

FYI, I want you to write this patch, I want to see what you come up with. But I want you to think about the above issues.

Thanks for reading my ramblings!
Back to top
llow
Cacti User


Joined: 05 Oct 2007
Posts: 88

PostPosted: Fri Oct 12, 2007 4:53 pm    Post subject: Reply with quote

I'll put something together. I am only planning on such functionality for the graphing portion as I would think most people would be using them for thresholds.
Back to top
llow
Cacti User


Joined: 05 Oct 2007
Posts: 88

PostPosted: Fri Oct 12, 2007 5:39 pm    Post subject: Reply with quote

Here is the patch.

Will need to increase varchar size as well to be useful...
ALTER TABLE graph_templates_graph MODIFY lower_limit VARCHAR(255);
ALTER TABLE graph_templates_graph MODIFY upper_limit VARCHAR(255);



cacti-0.8.7-beta4-lowerupperlimit-variable.patch
 Description:

Download
 Filename:  cacti-0.8.7-beta4-lowerupperlimit-variable.patch
 Filesize:  6.2 KB
 Downloaded:  213 Time(s)

Back to top
rony
Developer/Forum Admin


Joined: 17 Nov 2003
Posts: 5448
Location: Wisconsin, USA

PostPosted: Sat Oct 13, 2007 11:48 am    Post subject: Reply with quote

Please post a bug/feature for this, it easier for us to track.
Back to top
gandalf
Developer


Joined: 02 Dec 2004
Posts: 12206
Location: Muenster, Germany

PostPosted: Mon Feb 04, 2008 10:47 am    Post subject: Reply with quote

Implemented in SVN, targeted release is 088
Reinhard
Back to top
Display posts from previous:   
Post new topic   Reply to topic    Cacti Forum Index -> Feature Requests All times are GMT - 5 Hours
Page 1 of 1

 



Powered by phpBB © 2001, 2005 phpBB Group