[PATCH] INFOURL and OVERLIBGRAPH enhancements

llow · Cacti User Joined: 05 Oct 2007 Posts: 88

Patch adds the following features:

INFOURL for LINKs can be specified as "INFOURL url url" where the first url will be used for the input arrow and the second url for the output. "INFOURL url" will use the same url for both.

OVERLIBGRAPH for LINKs can be specified as "OVERLIBGRAPH url url" where the first image url will be used for the input overlib and the second url for the output. "OVERLIBGRAPH url" will use the same url for both.

OVERLIBGRAPH for NODEs can be specified as "OVERLIBGRAPH url ..." specifying as many image urls as you want. The images will be placed below one another.

I am thinking of implementing the following other enhancements:
OVERLIBGRAPHSIZE x y so that the images are scaled appropriately.
INOVERLIBGRAPH url ... so you can have more than one overlib image (replace changes made by my patch)
OUTOVERLIBGRAPH url ...
INNOTES notes text
OUTNOTES notes text
INOVERLIBCAPTION text
OUTOVERLIBCAPTION text

llow · Cacti User Joined: 05 Oct 2007 Posts: 88

I am also looking at making the NODE background change in color depending on a TARGET.

llow · Cacti User Joined: 05 Oct 2007 Posts: 88

Updated patch, if you have INFOURL or OVERLIBGRAPH in DEFAULT they will not be appended to the array if set specifically.

llow · Cacti User Joined: 05 Oct 2007 Posts: 88

llow · Cacti User Joined: 05 Oct 2007 Posts: 88

Patch adds "VIA node x y" with remaining support of "VIA x y". This allows for relative VIA points based on a node position.

This is done during the Draw and not during ReadConfig as I saw no need to iterate through the links and their vias before the Draw.

The line numbers may be off as I have other patch work I am doing.

Howie · Posted: Sat Dec 01, 2007 6:29 am Post subject:

Howie · Posted: Sat Dec 01, 2007 6:42 am Post subject:

Thanks!

You didn't say which version the patches are against, but I've also made a few small changes since 0.94 came out... 0.941 will be out this weekend and then I'll incorporate most of these changes (IN/OUT specific stuff, relative VIAs) in after that. I don't mind writing the code - incorporating patches always seems a bit fiddly - I always end up just cutting & pasting anyway

An appropriate WriteConfig section for each new syntax/keyword is needed too, so that the editor doesn't break it all.

Not sure about the image scaling one though - is that being done just by changing the width/height in the img tag? Weathermap doesn't know the aspect ratio of the image, so I guess it must be.

Relative VIA points is interesting, but I think it might conflict with the stuff already in the editor that rescales/rotates VIA points relative to the two nodes, when a node is moved... Once a VIA is positioned, when the node is moved, the editor will try and preserve the shape of the curved link. I suppose a relative-positioned VIA should take precedence. This will be useful once the straight-angled VIA code is finished.

You're right about the iteration. It's only relevant for NODEs relative to NODEs, because there can be a loop of ALL relatively-positioned nodes, then.

llow · Cacti User Joined: 05 Oct 2007 Posts: 88

The patches where against 0.9.4.

As far as the image scaling, it is not in either patch but I was looking at doing it in the img tag. The main use for it would be to scale down the image of other maps when linking between them. What does the OVERLIBHEIGHT and OVERLIBWIDTH really do? I can't get my head around it.

Howie · Posted: Sat Dec 01, 2007 12:32 pm Post subject: