|
|
| Author |
Message |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Mon Jan 18, 2010 8:22 am Post subject: Weathermap 0.97 Released |
|
|
After a long time in testing, mostly because I haven't had time to chase bugs, here is Weathermap 0.97.
Download is here, as usual:
http://www.network-weathermap.com/download
Changelog is:
| Code: |
FIXED - RRD Aggregation regexp was failing (thanks to shd)
FIXED - Scale numerals honour locale (thanks again, shd)
FIXED - THold plugin check failed with Thold 0.4.1 (PA 2.x, actually)
FIXED - Uninitialized variable in ReadData when plugin is disabled
FIXED - Zero-length link check didn't include offsets (thanks Ryan Botoluzzi)
FIXED - Cacti-pick should get right rra path for packagers that move the rra directory (e.g. Ubuntu, Debian *again*)
FIXED - DS plugins that return one value and a null should work properly
FIXED - "Strange" characters (e.g. /) in NODE and LINK names broke the imagemap.
FIXED - Map Style settings in editor were broken after internal defaults changes
FIXED - Imagemap no longer contains areas with no href defined
FIXED - SPLITPOS was ignored with VIASTYLE angled (thanks to uhtred)
FIXED - 'AICONOUTLINECOLOR none' is actually valid now (thanks to mgb & Leathon)
FIXED - readdir() loop never stops, on some systems (thanks to jerebernard)
FIXED - bad regexp in the MRTG DS plugin (thanks to Matt McMahon)
FIXED - 0.96 had a new 'time' DS plugin - now documented!
FIXED - NCFPC only complains about missing scale lines on NODEs for the variable that is in use.
ADDED - USEICONSCALE no longer has special dependencies - and the colours are nicer too.
ADDED - Option of a dropdown selector to navigate between maps (in full-size view)
ADDED - Maps can be organised into groups in Cacti plugin. These appear as tabs in the UI for viewing maps.
ADDED - Extra variables can be defined per-group, so all maps in a group can have similar settings (e.g. a "24hr average" tab).
ADDED - INCLUDE keyword to include a file of common definitions (based on work by BorisL)
(NOTE: this can confuse the editor sometimes - see the manual page for INCLUDE)
ADDED - Warning for maps that contain OVERLIBGRAPH but not 'HTMLSTYLE overlib'
ADDED - Warning for use of TEMPLATE not as the first line of an object (overwrites settings otherwise)
ADDED - SCALE will accept values below 0, and also above 100
ADDED - USESCALE has two new options: absolute and percent, which allows you to have a SCALE of absolute values
ADDED - New datasource plugin to support statistics from TheWitness's DSStats Cacti Plugin. This gets you daily,weekly,monthly and annual stats with no complicated rrdtool stuff.
ADDED - New converter to take a rrdtool-based map config and make it into a DSStats-based one
ADDED - static datasource can be used for negative values
ADDED - SNMP datasource has configurable timeout and retry values.
ADDED - SNMP datasource has option to give up on a failing host
ADDED - LABELOFFSET supports percentage compass offsets and radial offsets, like NODES does.
ADDED - Percentage compass offsets (NODES and LABELOFFSET) support > 100% offsets
|
|
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
|
| Back to top |
|
 |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Mon Jan 25, 2010 12:23 pm Post subject: |
|
|
| uhtred wrote: |
The problem is, u cant put the 'SET' command after the line using it.
Then, u get an warning:
ProcessString: {node:this:graph_id} refers to unknown item [WMWARN05] |
You can.
The token isn't evaluated until after the whole config file is read, and all the data is read, when the HTML is being written out. I just pasted that single node into a new config file and I didn't get that error.
Is this the very last node? If it is, what happens if you add another node after? |
|
| Back to top |
|
 |
inko_nick
Joined: 05 Dec 2008 Posts: 2
|
Posted: Tue Jan 26, 2010 2:54 am Post subject: |
|
|
Bug:
Settings > Page style > Show Only First - not work.
Patch: modify weathermap-cacti-plugin.php line 481
from> if($firstonly) { $query .= " LIMIT 1"; }
to> if($firstonly) { $maplist_SQL .= " LIMIT 1"; } |
|
| Back to top |
|
 |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Tue Jan 26, 2010 3:18 am Post subject: |
|
|
| inko_nick wrote: | Bug:
Settings > Page style > Show Only First - not work.
Patch: modify weathermap-cacti-plugin.php line 481
from> if($firstonly) { $query .= " LIMIT 1"; }
to> if($firstonly) { $maplist_SQL .= " LIMIT 1"; } |
Thanks. It'll be in 0.97a |
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
Posted: Tue Jan 26, 2010 4:16 am Post subject: |
|
|
ok, i found the failure.
the problem was a failure in my config. there was a {node:this:graph_id} in a link section, although it has to be {link:this:graph_id}.
But there seems to be a bug with the error messages.
Cause i get 4 messages of ProcessString: {node:this:graph_id} refers to unknown item [WMWARN05], although there is only 1 failure in the file (see above). |
|
| Back to top |
|
 |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Tue Jan 26, 2010 4:32 am Post subject: |
|
|
| uhtred wrote: | ok, i found the failure.
the problem was a failure in my config. there was a {node:this:graph_id} in a link section, although it has to be {link:this:graph_id}.
But there seems to be a bug with the error messages.
Cause i get 4 messages of ProcessString: {node:this:graph_id} refers to unknown item [WMWARN05], although there is only 1 failure in the file (see above). |
I will alter the message so that it includes the context (the node or link that is considered 'this') in the message - at least then you can see what is going on better. It's possible that the infourl or overlibgraph gets processed in more than one place - I'll check. |
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
Posted: Thu Jan 28, 2010 9:29 am Post subject: |
|
|
hi,
i did add a node for changing background color, but the editor seems to have a problem with it.
background node:
NODE statenode
ZORDER 1
USESCALE bg in
ICON 1200 1200 box
AICONOUTLINECOLOR none
LABELOUTLINECOLOR none
AICONFILLCOLOR copy
LABELOFFSET C
POSITION 600 600
TARGET cactihost:61 ...
MAXVALUE 48
if i open the conf with the editor and select some node or links, it will allways open the 'statenode' from above. The only object i can select, is the legend.
Do i use a wrong zorder or is it a bug? |
|
| Back to top |
|
 |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Mon Feb 01, 2010 3:46 am Post subject: |
|
|
| uhtred wrote: | hi,
i did add a node for changing background color, but the editor seems to have a problem with it.
background node:
NODE statenode
ZORDER 1
USESCALE bg in
ICON 1200 1200 box
AICONOUTLINECOLOR none
LABELOUTLINECOLOR none
AICONFILLCOLOR copy
LABELOFFSET C
POSITION 600 600
TARGET cactihost:61 ...
MAXVALUE 48
if i open the conf with the editor and select some node or links, it will allways open the 'statenode' from above. The only object i can select, is the legend.
Do i use a wrong zorder or is it a bug? |
I had problems with this last week too. It seems the sort order is wrong for the imagemap - if one node ovrerlaps with another, it's the lower one that is selected. I thought I had fixed this a long time ago, so I'll take another look. |
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
Posted: Tue Feb 02, 2010 8:16 am Post subject: |
|
|
ok, i found another bug, when using the editor.
try to use NOTES with an iframe :
it have to look like this:
NOTES <iframe width=\"400px\" height=\"350px\" src=\"/cacti/plugins/weathermap/info.php?node=63\"> </iframe>
if u add this iframe with editor:
NOTES <iframe width="400px" height="350px" src="/cacti/plugins/weathermap/info.php?node=63"></iframe>
the result is:
NOTES <iframe width=\"400px\" height=\"350px\" src=\"/cacti/plugins/weathermap/info.php?node=63\"> </iframe>
thats fine.
But if u open the node again, to change some parameter and save again....
NOTES <iframe width=\\\\"400px\\\\" height=\\\\"350px\\\\" src=\\\\"/cacti/plugins/weathermap/info.php?node=63\\\\"> </iframe>
...and the iframe doesn't work anymore.
so there is a bug in matching special characters.
greetz |
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
Posted: Fri Feb 05, 2010 8:17 am Post subject: |
|
|
hi,
1 question:
my cacti stop polling, if there are some critical failures in a weathermap. Is it a normal behavior?
i.e. i changed nodename in a map , but i forgot to change the nodenames using by the links.
greetz |
|
| Back to top |
|
 |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Fri Feb 05, 2010 8:20 am Post subject: |
|
|
| uhtred wrote: | hi,
1 question:
my cacti stop polling, if there are some critical failures in a weathermap. Is it a normal behavior?
i.e. i changed nodename in a map , but i forgot to change the nodenames using by the links.
greetz |
That shouldn't be a critical failure... just a warning. What PHP error do you see that kills the poller?
(the editor would have done the renaming for you, by the way - I know that it will break other things for you at the moment ) |
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
Posted: Fri Feb 05, 2010 8:31 am Post subject: |
|
|
i mostly use vi
cactilog shows something like this:
02/05/2010 01:05:01 PM - POLLER: Poller[0] WARNING: Cron is out of sync with the Poller Interval! The Poller Interval is '60' seconds, with a maximum of a '300' second Cron, but 600 seconds have passed since the last poll!
02/05/2010 12:55:39 PM - WEATHERMAP: Poller[0] WARNING: [Map 6] x.conf: Unknown node 'dev' on line 565 of config |
|
| Back to top |
|
 |
Howie Cacti Guru User
Joined: 16 Sep 2004 Posts: 3772 Location: United Kingdom
|
Posted: Fri Feb 05, 2010 9:51 am Post subject: |
|
|
| uhtred wrote: | i mostly use vi
cactilog shows something like this:
02/05/2010 01:05:01 PM - POLLER: Poller[0] WARNING: Cron is out of sync with the Poller Interval! The Poller Interval is '60' seconds, with a maximum of a '300' second Cron, but 600 seconds have passed since the last poll!
02/05/2010 12:55:39 PM - WEATHERMAP: Poller[0] WARNING: [Map 6] x.conf: Unknown node 'dev' on line 565 of config |
Most of Weathermap runs after the main poller has run. If it didn't update any rrds for that poll, then that isn't because of the warning you have there - that happens after the main poll. The only part of Weathermap that *might* have that kind of effect on Cacti polling is the poller_output stuff in setup.php - you could prove if that was causing the problem or not by removing/commenting the $plugin_hooks line for poller_output in the plugin_init_weathermap function in setup.php.
Obviously this will stop poller_output/Boost support working in weathermap, too. |
|
| Back to top |
|
 |
uhtred Cacti User
Joined: 09 Oct 2009 Posts: 50 Location: Germany
|
Posted: Mon Feb 08, 2010 7:47 am Post subject: |
|
|
...so the best way, i think: don't make mistakes when creating a map  |
|
| Back to top |
|
 |
|