THOLD redeclares png2jpg

Support questions about the Threshold plugin

Moderators: Moderators, Developers

Post Reply
Author
Message
User avatar
GlueGuy
Cacti User
Posts: 255
Joined: Fri Nov 04, 2005 3:37 pm
Location: Ca US
Contact:

THOLD redeclares png2jpg

#1 Post by GlueGuy » Sun Jul 23, 2017 9:43 pm

We're attempting to migrate from 0.8.8h to 1.1.13. When we installed the THOLD plugin (v 0.5), we get the following error.
2017/07/23 16:56:28 - ERROR PHP COMPILE_ERROR in Plugin 'thold': Cannot redeclare png2jpeg() (previously declared in /usr/share/cacti/site/lib/reports.php:1244) in file: /usr/share/cacti/site/plugins/thold/thold_functions.php on line: 3054
2017/07/23 16:56:28 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'thold'
---------
The Glue Guy

User avatar
GlueGuy
Cacti User
Posts: 255
Joined: Fri Nov 04, 2005 3:37 pm
Location: Ca US
Contact:

Re: THOLD redeclares png2jpg

#2 Post by GlueGuy » Sun Jul 23, 2017 9:52 pm

So I commented out that redundant function. I am now getting hung up on an undeclared function split() coming from thold/includes/polling.php
2017/07/23 19:44:14 - ERROR PHP ERROR in Plugin 'thold': Uncaught Error: Call to undefined function split() in /usr/share/cacti/site/plugins/thold/includes/polling.php:28
2017/07/23 19:37:44 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'thold'
---------
The Glue Guy

User avatar
GlueGuy
Cacti User
Posts: 255
Joined: Fri Nov 04, 2005 3:37 pm
Location: Ca US
Contact:

Re: THOLD redeclares png2jpg

#3 Post by GlueGuy » Sun Jul 23, 2017 10:10 pm

OK. Replaced split() with explode() per some bug reports I saw on the web regarding issues with Debian and PHP 7.

THOLD now seems to be working. Do this:
  • Comment out png2jpg
  • Replace split() with explode()
---------
The Glue Guy

cigamit
Developer
Posts: 2784
Joined: Thu Apr 07, 2005 3:29 pm
Location: B/CS Texas
Contact:

Re: THOLD redeclares png2jpg

#4 Post by cigamit » Mon Jul 24, 2017 12:59 pm

If you are using the 1.X releases of Cacti, you need to be using the latest version of Thold.
https://github.com/Cacti/plugin_thold/
The old version 0.5 isn't compatible with the latest Cacti, not sure how you even got past the Plugin Management page to install it, as it shouldn't have let you.

User avatar
GlueGuy
Cacti User
Posts: 255
Joined: Fri Nov 04, 2005 3:37 pm
Location: Ca US
Contact:

Re: THOLD redeclares png2jpg

#5 Post by GlueGuy » Mon Jul 24, 2017 1:31 pm

Sheesh. I must have missed the memo on this. I will say that I had to do some editing of THOLD to get it to run.

It fell on its face again after I wrote my last entry on this. I'll D/L the new THOLD and see how it goes.

Thanks Jimmy!
---------
The Glue Guy

Post Reply