Change to take interface status make it works

Anything that you think should be in Cacti.

Moderators: Moderators, Developers

Post Reply
Author
Message
Rno
Cacti User
Posts: 325
Joined: Wed Dec 07, 2011 9:19 am

Change to take interface status make it works

#1 Post by Rno » Mon May 08, 2017 4:05 am

I thing there was a request to change the REGEXP_SNMP_TRIM into snmp.php to be able to query the interface status long time ago, and still not changed !

Is it planed to do it in a future release ?
And it will not change the functionallity of snmp.php

It will change for the following value:
define("REGEXP_SNMP_TRIM", "/(hex|counter(32|64)|gauge|gauge(32|64)|float|ipaddress|string|integer):|(up|down)\(|\)$/i");


and changing the interface.xml the following way will alos solve the issue:
<ifOperStatus>
<name>Status</name>
<method>walk</method>
<source>VALUE/REGEXP:[a-zA-Z]{1,}\(([1-]{1})+\)$</source>
<direction>output</direction>
<oid>.1.3.6.1.2.1.2.2.1.8</oid>
</ifOperStatus>

Source and direction

thanks
CentOS
Production
Cacti 0.8.8h
Spine 0.8.8h
PIA 3.1
Aggregate 0.75
Monitor 1.3
Settings 0.71
Weathermap 0.98
Thold 0.5
rrdclean 0.41

Own plugin: LinkDiscovery 0.3, Map 0.4

Test
Cacti 1.2.1
Spine 1.2.1
thold 1.0.6
monitor 2.3.5
php 7.2.11
mariadb 5.5.56
Own plugin:
ExtendDB 1.1.2
LinkDiscovery 1.2.4
Map 1.2.5

User avatar
Osiris
Cacti Pro User
Posts: 835
Joined: Mon Jan 05, 2015 10:10 am

Re: Change to take interface status make it works

#2 Post by Osiris » Tue May 09, 2017 10:16 pm

Two words "pull request"
Before history, there was a paradise, now dust.

Rno
Cacti User
Posts: 325
Joined: Wed Dec 07, 2011 9:19 am

Re: Change to take interface status make it works

#3 Post by Rno » Wed May 10, 2017 1:56 am

One quick question, In a pool request, should just put the code I propose to change, or can I do more ?
Text of explanation of what to do or whatever.

Sorry to ask that but I'm willing to do it, but need to be sure of what I'm doing !
CentOS
Production
Cacti 0.8.8h
Spine 0.8.8h
PIA 3.1
Aggregate 0.75
Monitor 1.3
Settings 0.71
Weathermap 0.98
Thold 0.5
rrdclean 0.41

Own plugin: LinkDiscovery 0.3, Map 0.4

Test
Cacti 1.2.1
Spine 1.2.1
thold 1.0.6
monitor 2.3.5
php 7.2.11
mariadb 5.5.56
Own plugin:
ExtendDB 1.1.2
LinkDiscovery 1.2.4
Map 1.2.5

User avatar
Osiris
Cacti Pro User
Posts: 835
Joined: Mon Jan 05, 2015 10:10 am

Re: Change to take interface status make it works

#4 Post by Osiris » Wed May 10, 2017 4:32 am

Look at some of the dozens that have been logged and committed already.
Before history, there was a paradise, now dust.

Rno
Cacti User
Posts: 325
Joined: Wed Dec 07, 2011 9:19 am

Re: Change to take interface status make it works

#5 Post by Rno » Wed May 10, 2017 8:59 am

Well I try to create one, but so far I just add some comment, and I can find 4 files on my pull request
Bu none of then where added by my

Sorry, but I'm not an expert of githut, and I can't find any help on it !!
I'm not even sure the base is master, the compare is develop!
So looking at all that where done before, dosen't help of how to do it!!


Any help to help will be nice
CentOS
Production
Cacti 0.8.8h
Spine 0.8.8h
PIA 3.1
Aggregate 0.75
Monitor 1.3
Settings 0.71
Weathermap 0.98
Thold 0.5
rrdclean 0.41

Own plugin: LinkDiscovery 0.3, Map 0.4

Test
Cacti 1.2.1
Spine 1.2.1
thold 1.0.6
monitor 2.3.5
php 7.2.11
mariadb 5.5.56
Own plugin:
ExtendDB 1.1.2
LinkDiscovery 1.2.4
Map 1.2.5

User avatar
Osiris
Cacti Pro User
Posts: 835
Joined: Mon Jan 05, 2015 10:10 am

Re: Change to take interface status make it works

#6 Post by Osiris » Mon May 15, 2017 12:51 am

Well one day you will move from your 'githut' to a real live GitHub. Wait for you moment, and make it happen.
Before history, there was a paradise, now dust.

Rno
Cacti User
Posts: 325
Joined: Wed Dec 07, 2011 9:19 am

Re: Change to take interface status make it works

#7 Post by Rno » Mon May 15, 2017 2:10 am

After 3 tests, i was able to do it,
and the 2 changes proposed where accepted.

I'm not sur I can't say thanks for the help !!
CentOS
Production
Cacti 0.8.8h
Spine 0.8.8h
PIA 3.1
Aggregate 0.75
Monitor 1.3
Settings 0.71
Weathermap 0.98
Thold 0.5
rrdclean 0.41

Own plugin: LinkDiscovery 0.3, Map 0.4

Test
Cacti 1.2.1
Spine 1.2.1
thold 1.0.6
monitor 2.3.5
php 7.2.11
mariadb 5.5.56
Own plugin:
ExtendDB 1.1.2
LinkDiscovery 1.2.4
Map 1.2.5

Post Reply